[mlir] Update vector return types for .getMixed* methods (NFC)
#133821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop small size to make vector types match the generic helper `getMixedValues` in `StaticValueUtils.h`.
Member
|
@llvm/pr-subscribers-mlir Author: Jakub Kuderski (kuhar) ChangesDrop small size to make vector types match the generic helper This saves some needles vector copies. I didn't find any local variables that need updating. Full diff: https://github.com/llvm/llvm-project/pull/133821.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Interfaces/ViewLikeInterface.td b/mlir/include/mlir/Interfaces/ViewLikeInterface.td
index 9397f271e1bc6..d1401c238381e 100644
--- a/mlir/include/mlir/Interfaces/ViewLikeInterface.td
+++ b/mlir/include/mlir/Interfaces/ViewLikeInterface.td
@@ -160,7 +160,7 @@ def OffsetSizeAndStrideOpInterface : OpInterface<"OffsetSizeAndStrideOpInterface
/*desc=*/[{
Return a vector of all the static or dynamic offsets of the op.
}],
- /*retTy=*/"::llvm::SmallVector<::mlir::OpFoldResult, 4>",
+ /*retTy=*/"::llvm::SmallVector<::mlir::OpFoldResult>",
/*methodName=*/"getMixedOffsets",
/*args=*/(ins),
/*methodBody=*/"",
@@ -174,7 +174,7 @@ def OffsetSizeAndStrideOpInterface : OpInterface<"OffsetSizeAndStrideOpInterface
/*desc=*/[{
Return a vector of all the static or dynamic sizes of the op.
}],
- /*retTy=*/"::llvm::SmallVector<::mlir::OpFoldResult, 4>",
+ /*retTy=*/"::llvm::SmallVector<::mlir::OpFoldResult>",
/*methodName=*/"getMixedSizes",
/*args=*/(ins),
/*methodBody=*/"",
@@ -188,7 +188,7 @@ def OffsetSizeAndStrideOpInterface : OpInterface<"OffsetSizeAndStrideOpInterface
/*desc=*/[{
Return a vector of all the static or dynamic strides of the op.
}],
- /*retTy=*/"::llvm::SmallVector<::mlir::OpFoldResult, 4>",
+ /*retTy=*/"::llvm::SmallVector<::mlir::OpFoldResult>",
/*methodName=*/"getMixedStrides",
/*args=*/(ins),
/*methodBody=*/"",
|
kuhar
changed the title
.getMixed* methods NFC..getMixed* methods (NFC)
MaheshRavishankar
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop small size to make vector types match the generic helper
getMixedValuesinStaticValueUtils.h.This saves some needles vector copies. I didn't find any local variables that need updating.